You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We just need to pass on CssInliner::$debug through Pelago\Emogrifier\Css\CssDocument to Sabberworm\CSS\Parser, mostly with one line of code to be added:
This will resolve one of the failing tests in #1129.
But life is never simple. Simply applying the requried code change leads to a whole bunch of additional test failures, which need to be looked into. On initial glance, quite a few are because we expect an exception for malformed CSS but would now be getting a different class of exception. But there are other failures of a different nature too.
The text was updated successfully, but these errors were encountered:
This partially addresses both #1139 and #1140.
However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.
Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
This partially addresses both #1139 and #1140.
However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.
Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
This partially addresses both #1139 and #1140.
However, if the CSS contains nested at-rules, the debug setting won't currently
be passed on, due to MyIntervals/PHP-CSS-Parser#127.
Some tests have been adapted to cater for an exception in debug mode with only
some of the data.
See MyIntervals/PHP-CSS-Parser#346.
We just need to pass on
CssInliner::$debug
throughPelago\Emogrifier\Css\CssDocument
toSabberworm\CSS\Parser
, mostly with one line of code to be added:This will resolve one of the failing tests in #1129.
But life is never simple. Simply applying the requried code change leads to a whole bunch of additional test failures, which need to be looked into. On initial glance, quite a few are because we expect an exception for malformed CSS but would now be getting a different class of exception. But there are other failures of a different nature too.
The text was updated successfully, but these errors were encountered: