Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update the development tools #1121

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Conversation

oliverklee
Copy link
Contributor

@oliverklee oliverklee commented Dec 10, 2021

Also reorder the entries in the composer.json to match the rules
of the latest composer-normalize version.

@oliverklee oliverklee added this to the 7.0.0 milestone Dec 10, 2021
@oliverklee oliverklee self-assigned this Dec 10, 2021
@oliverklee oliverklee force-pushed the task/update-phive-tools branch from c5834db to 870b57f Compare December 10, 2021 09:39
@oliverklee oliverklee changed the title Task/update phive tools [TASK] Update the development tools Dec 10, 2021
@oliverklee oliverklee force-pushed the task/update-phive-tools branch from 870b57f to 0170991 Compare December 10, 2021 09:59
@oliverklee oliverklee marked this pull request as ready for review December 10, 2021 10:01
@oliverklee oliverklee requested a review from JakeQZ December 10, 2021 10:01
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to update the minimum Psalm version?

.phive/phars.xml Outdated Show resolved Hide resolved
@oliverklee oliverklee force-pushed the task/update-phive-tools branch from 0170991 to 7de861b Compare December 16, 2021 18:38
@oliverklee oliverklee requested a review from JakeQZ December 16, 2021 18:38
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 17, 2021

I'm happy to work the the current known build failures if you are happy to use your superhero powers to commit changes.

However, neither test failures are straightforward to fix, and it may be some time (one would require a new release of a 3rd party component, and for the other, see #1139).

Maybe we should temporarily disable the failing tests, so as to avoid any mistakes propagating to main - ? (Obviously we should create issues to make sure we put the tests back in.)

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 17, 2021

Build might be green after a rebase, as a result of #1138.

Also reorder the entries in the `composer.json` to match the rules
of the latest composer-normalize version.
@oliverklee oliverklee force-pushed the task/update-phive-tools branch from 7de861b to 60135e7 Compare December 17, 2021 10:32
@oliverklee oliverklee merged commit f737d46 into main Dec 17, 2021
@oliverklee oliverklee deleted the task/update-phive-tools branch December 17, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants