Fix Issues with Makefile in circom-circuit Directory #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update in the
myna-wallet-monorepo/packages/circom-circuit
package's Makefile addresses specific issues related to directory creation and file paths. The changes enhance the overall functionality and ensure the correct setup for circuit compilation and verification.Key Changes
Directory Creation Command Improvement: Updated the
init
target frommkdir ./setup && mkdir ./build
tomkdir -p ./setup && mkdir -p ./build
. This change prevents errors if directories already exist.Updating Powers of Tau File Download URL: Changed the curl command from downloading
powersOfTau28_hez_final_19.ptau
topowersOfTau28_hez_final_20.ptau
, ensuring the script uses the latest version of the file.. Correct File Paths for Powers of Tau Files: Adjusted file paths in
gov-sig-build-circuit
anduser-sig-build-circuit
targets.Related Issue
#50