Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow - Add macos-14 for both arm64 and x86_64 #854

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Github Workflow - Add macos-14 for both arm64 and x86_64 #854

merged 3 commits into from
Feb 12, 2024

Conversation

jhoyt4
Copy link
Contributor

@jhoyt4 jhoyt4 commented Feb 4, 2024

Updates include:

  • Updates for macos-14 runer which is arm64, but allows compilation on x86_64 via Rosetta 2
  • The addition of a manual workflow trigger (allows a developer to run the CI on a branch other than master)
  • lint clean up based on yamllint
Checklist

The macos-14 runner only runs on arm64 (currently).  This means that
to test on x86_64 intel, a cross compile capability using Rosetta2's
arch function is necessary to test builds for that architecture.

Additionally, adding several missing brew packages for a more complete
build test.
Occasionally, workflows / github actions fail due to runner errors.
Adding a manual workflow test allows a developer to manually kick off
another test without having to commit to the code.

Additionally, this new function allows users to manually run the
workflow for branches other than master (e.g. when they want to test
fixes/33)
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Feb 5, 2024

The failing CI check is due to an upstream homebrew issue. If someone can tell it to re-run, it should pass like it did on the fork before I issued this PR (https://github.com/jhoyt4/mythtv/actions/runs/7777340340)

@linuxdude42 linuxdude42 merged commit 8cbe197 into MythTV:master Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants