fix(ci): use dedicated staging environment config in ci #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Do we need to update the secret used here as well? https://github.com/NASA-IMPACT/veda-auth/blob/main/.github/workflows/pr.yml#L19 |
Yes--I will fix it! Thanks! EDIT: I had both the pr and cicd ymls updated 😅 There will be some administrative update actions in env secrets for lower environments |
smohiudd
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Github automated pr and push workflows updated to use a new aws secrets manager config in
veda-auth-staging-envto avoid causing changes to legacy uah auth stack that is used by unmaintained but still supported services like veda-stac-ingestor. The result will be that we have two automatically deployed auth stacks (dev and staging) and will no longer automatically update the existing veda-auth-stack-uah.Why
Caution. The most recent update to veda-auth-stack-dev which had not been redeployed for over a year caused a change to the programmatic client id. It is not clear that these changes would impact the uah stack but, just in case, let's add a new more logically named staging auth stack for our staging veda system.