chore: Remove veda dependency #1398
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
requested review from
sandrahoang686,
dzole0311,
AliceR and
snmln
There was a problem hiding this comment.
I don't think VedaUIProvider is the best place, this provider has been a workaround for us to handle env vars and workarounds for framework related things (routing). It would be great if we could keep the usecase for it limited.
I also think we dont need it as part of context and could just isolate to the hook. It looks like pretty simple logic where all its being used for is to just show/not show something so this could be entirely simplified. Really, we dont even need the hook but created a PR to this branch here to make said changes if you could take a look (this should also fix the tests because no more dep on provider).
**Changes:** #1398 (review) <img width="807" alt="Screenshot 2025-01-22 at 6 30 42 PM" src="https://github.com/user-attachments/assets/01635c17-d006-4b60-a83d-71e3dcb273e2" />
Related Ticket: #1360
This PR removes VEDA dependency from the registry build. Run
yarn buidliblocally, see how less number of assets it builds to test it. (PageHeader and PageFooter were the root of the cause)Compare it to : #1367
It is kind of difficult to think what kind of test we can do check this, but it will be nice to have some automatic checks - since it is much easier to get rid of veda dependency when you know what directly introduced it.