fix: Remove the USWDS button from the old page header #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
changed the title
dzole0311
added a commit
that referenced
this pull request
Feb 10, 2025
**Related Ticket:** closes #1388 During the recent header redesign, we created a "legacy" version of the old header to keep consistency across existing deployments (like GHG Center) and to ease the development process. However, a USWDS-styled button had accidentally been included in this legacy header and it's causing visual inconsistency with the original GHG Center design. This PR removes the USWDS button from the legacy header and replaces it with the previous styled button (that was removed here https://github.com/NASA-IMPACT/veda-ui/pull/1247/files#diff-3dc664e136e6e14925e5f449b907df7edc49fd1d2744cf0cb1aea27a63646846L51). _{Add additonal notes and outstanding questions here related to changes in this pull request}_ 1. Verify that the new header is shown as usual in the veda UI 1. Verify that the "Contact Us" button is not a USWDS button in the [GHG Center preview deployment](US-GHG-Center/veda-config-ghg#728) and verify that it matches some of the earlier deployments of GHG Center (example of an older deployment: https://deploy-preview-455--ghg-demo.netlify.app/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: closes #1388
Description of Changes
During the recent header redesign, we created a "legacy" version of the old header to keep consistency across existing deployments (like GHG Center) and to ease the development process. However, a USWDS-styled button had accidentally been included in this legacy header and it's causing visual inconsistency with the original GHG Center design. This PR removes the USWDS button from the legacy header and replaces it with the previous styled button (that was removed here https://github.com/NASA-IMPACT/veda-ui/pull/1247/files#diff-3dc664e136e6e14925e5f449b907df7edc49fd1d2744cf0cb1aea27a63646846L51).
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing