Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch missing summaries on api data #769

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

danielfdsilva
Copy link
Collaborator

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 0258447
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/656de1343872da0008810e06
😎 Deploy Preview https://deploy-preview-769--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielfdsilva danielfdsilva requested a review from j08lue December 4, 2023 10:23
Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I can test this (using the Netlify preview), since the dataset in question does not seem to be in the mock data.

I get a critical error on the OCO2 dataset, though - is that related?

https://deploy-preview-769--veda-ui.netlify.app/data-catalog/oco2-geos-l3-daily/explore

I'll approve here anyways, since the change is so small.

@danielfdsilva
Copy link
Collaborator Author

@j08lue It is related.

We look for the data domain under summaries.datetime, and when not available, we default to extent.temporal.interval. In that dataset's case they're both null, so there's nothing we can do. I did however handle the error better, so only the layer fails, and it is not a critical one.

image image

@danielfdsilva danielfdsilva merged commit 44f6345 into main Dec 4, 2023
7 checks passed
@danielfdsilva danielfdsilva deleted the fix/missing-summaries branch December 4, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMIP6 dataset via TiTiler-Xarray causes critical error
2 participants