Update jparser to handle missing object_length in delimited tables
#109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanpadams
requested changes
Dec 6, 2023
remove deadcode
jordanpadams
approved these changes
Dec 7, 2023
jordanpadams
changed the title
object_length in delimited tables
jordanpadams
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Default for delimited table size when nothing is given was file size. Changed to 0. Basically, we just punt this metadata check and allow content validation to catch any issues in the table definitions.
⚙️ Test Data and/or Report
All NASA-PDS/validate#783 automate unit tests should pass
♻️ Related Issues
NASA-PDS/validate#781