Create new error.connection.registry to avoid internal errors being thrown for registry connection issues
#1091
Conversation
| @@ -44,6 +44,8 @@ public enum ProblemType { | |||
|
|
|||
| CONTEXT_REFERENCE_NOT_FOUND("error.label.context_ref_not_found"), | |||
|
|
|||
| CONNECTION_ERROR("error.connection.registry"), | |||
There was a problem hiding this comment.
Make the characters inside quotes anything you want.
There was a problem hiding this comment.
✅ Visual inspection looks good
✅ Testing looks good
WARNING] Tests run: 252, Failures: 0, Errors: 0, Skipped: 23
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:37 min
Approved!
Unnecessary import
|
|
@al-niessner @nutjob4life For our PR reviews, can we also include reviews of the titles of the PRs to be end-user readable? Those are used to generate the release notes automatically. Unfortunately, however GitHub does it you can't update them after the PR has been merged (maybe merge commits?) |
jordanpadams
changed the title
error.connection.registry to avoid internal errors being thrown for registry connection issues
|
@jordanpadams I thought the release notes were generated from issues, not pull requests. Is it both? |
|
@nutjob4life the CHANGELOG is generated using issues, GitHub release notes are generated using PR titles: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes . The intent being that CHANGELOGs are more for developers/owners of the software, versus release notes are intended for the end user to know what was actually done. We can manually update the release notes that GitHub generates, so it isn't the end of the world, it just helps @tloubrieu-jpl and I when we need to tag a release |
|
@jordanpadams - that is 100% subjective judgement call which means you are signing up to all PR merges. Sidebar: you can modify the script that does it; meaning write your own then replace it and remove |
|
@jordanpadams thanks! |
🗒️ Summary
Added new ProblemType.CONNECTION_ERROR and changed internal error to this.
⚙️ Test Data and/or Report
All unit tests below pass and visual inspection of code changes.
♻️ Related Issues
Closes #1085