Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional changes needed during normalization process #363

Closed
MarkDWilliams opened this issue Mar 1, 2023 · 2 comments
Closed

Additional changes needed during normalization process #363

MarkDWilliams opened this issue Mar 1, 2023 · 2 comments
Assignees

Comments

@MarkDWilliams
Copy link
Collaborator

Ref: NCATSTranslator/Feedback#134
During the course of changing nodes in results and knowledge_graph as part of the node normalization process, we neglected to apply these same changes to subject and object fields on edges. These changes should be extended to include the CURIEs which exist as values for subject and object on KG edges as well.

@cbizon
Copy link
Contributor

cbizon commented Mar 1, 2023

FWIW, there is a (badly-named) endpoint on NN /response that normalizes an entire TRAPi response. It normalizes the nodes as well as the edges, and it supposedly handles the case where e.g. two nodes on the input KG normalize into a single node on output. I say supposedly b/c I don't think it has ever gotten used widely, but you may find it useful either from calling or from looking at its implmentation.

@MarkDWilliams
Copy link
Collaborator Author

Good looking out. I did not recall that and will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants