Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inactive: Make component optionally a list #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cbizon
Copy link

@cbizon cbizon commented Jul 2, 2021

Many teams use BTE (identified as an ARA) as a KP since it provides a trapi interface to non-trapi services. This requires special casing in the calling ARAs, so it would be nice if BTE were able to identify as both a KP and an ARA in the registry. This change would allow that.

For simplicity, but at the cost of losing backwards compatibility, the oneOf could be removed in place of just converting the string value of component to an array value.

Many teams use BTE (identified as an ARA) as a KP since it provides a trapi interface to non-trapi services.    This requires special casing in the calling ARAs, so it would be nice if BTE were able to identify as both a KP and an ARA in the registry.   This change would allow that.

For simplicity, but at the cost of losing backwards compatibility, the oneOf could be removed in place of just converting the string value of component to an array value.
@colleenXu
Copy link
Collaborator

Not sure if that would break some of the code around the metakg (recognizing what is a KP vs ARA) / summary for the component to be a list. @newgene ?

@colleenXu
Copy link
Collaborator

@andrewsu to comment on the code-breaking part.

@andrewsu
Copy link

@cbizon after discussion at our team meeting, we propose not making this change at this time, for two reasons. First, since allowing multiple values would only apply to BTE right now (right?), it seems better to handle that as a special case rather than change the spec. Second, this change would break our SmartAPI metakg tool, and given pressing timelines, we'd rather not have to add another thing to our plate.

We do understand the potential benefits to consumers by making this change, but given that ARAs that want to call BTE as a KP have already implemented whatever special logic they need to get things to work, we propose to delay this until at least after the December demo. Are there other factors that we aren't considering here?

@cbizon
Copy link
Author

cbizon commented Jul 19, 2021

No, I don't know of any other factors. I think that's a reasonable approach.

@colleenXu
Copy link
Collaborator

Leaving this PR open as a "phantom"/"inactive", to potentially revisit later.

@colleenXu colleenXu changed the title Make component optionally a list inactive: Make component optionally a list Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants