-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure postgres connections are closed properly and other minor changes #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also use try with resources statements to make sure the connections get closed
also increase the number of possible connections everywhere
artntek
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a big fan of reformatting files to comply with the codestyle settings. There are a couple of gotchas to watch out for, though:
- If I reformat an entire file, I can't trust the IDE completely. I always find I need to look through the resulting code and make manual tweaks to the formatting/flow, because it doesn't wrap javadoc comments well, for example, or breaks concatenated strings over multiple lines needlessly etc. I flagged a few of these in your code below, but there were many more I didn't flag.
- When you reformat an entire file, it's almost impossible for a reviewer to find the actual code changes you have made, so they may miss an important detail. The best approach is to split the reformatting and the code changes across 2 separate PRs, but since that's not always possible, a good alternative is to at least push separate commits for the reformat and the code changes. Failing both of those, a final option is to addd some comments to the PR to show where the actual code changes are.
I searched for try (
, so found your changes, but I hope I didn't miss anything else :-)
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ucsb/nceas/mdqengine/scheduler/RequestReportJob.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses:
dispatch.setupJep()
#416