update example and usage info for -dp/--package flag #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix downloadcmd example syntax
Update usage info for package argument
|
@agt24 these changes in argparse aren't compatible with subsequent logic for how downloadcmd 'decides' what it should be doing. I am working on a local branch that updates that logic to be compatible with variables rather than boolean True/False 'flags', which is how the tool's logic currently works. See for what I'm referring to.Also coming up with some basic integration tests as @yarikoptic pointed out, there are no tests so it's hard to tell if changes break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to example in README.md and in usage info based on info from @obenshaindw in help ticket #97692