Client silently ignores PEM file if user expansion is needed

[MrCreosote]

sfapi_client/src/sfapi_client/_async/client.py

Lines 314 to 317 in 467c2cc

	def _read_client_secret_from_file(self, name):
	if name is not None and Path(name).exists():
	# If the user gives a full path, then use it
	key_path = Path(name)

If name is something like ~/NERSC/key.pem then Path.exists() will return False, even though the file does exist at that location, and the client will remain unauthenticated, which is very confusing.

There's at least two options that could be reasonable:

1. Add Path.expanduser() after each Path constructor call
2. Throw an error if expanduser() results in a different path if you want to force the user to provide an absolute path or path relative to the working dir

[cjh1]

@MrCreosote Thanks for report. I think your first suggest is probably the way to go. @tylern4 would you be able to take a look at fixed this up, as I am currently out of action.

[MrCreosote]

If it's just a matter of adding the expanduser calls and manually testing I can PR it if you want. I hesitated before because

• I hadn't looked at the tests, but it seems like there are no tests for the key= case, so it's just a matter of testing manually
• I'm not sure what platforms you're supporting and if expanduser would cause problems on Windows.

If adding the calls, testing on linux, and making a PR agrees with you LMK and I'll do it today

[MrCreosote]

Looks like the code is duplicated in _sync/client.py as well