85 client silently ignores pem file if user expansion is needed

[tylern4]

Checks to get full path of file and if the file isn't found raises an error.

[cjh1]

Lets add to the docstring for key that is will be expanding using expanduser(), so it will be clear what the behavior will be. Can we also add a simple test to confirm the exception is throw?

[tylern4]

I've added a few tests for the key file now.

[cjh1]

Looking good, thanks for adding the tests. One inline comment.

[cjh1]

Sorry all the operations that could raise an exception should be in the try block, so like this:

   try:
       tmp_path_factory._basetemp = Path().home()
       key_path = tmp_path_factory.mktemp(".sfapi_test1", numbered=False) / "key.pem"

        # Make a fake key for testing
        key_path.write_text(
        f"""abcdefghijlmo
-----BEGIN RSA PRIVATE KEY-----
{rsa.generate_private_key(public_exponent=65537, key_size=2048)}
-----END RSA PRIVATE KEY-----
"""
        )
        key_path.chmod(0o100600)
        
        yield key_path
    finally:
        # make sure to cleanup the test since we put a file in ~/.sfapi_test
        temp_path = Path().home() / ".sfapi_test1"
        if temp_path.exists():
            (temp_path / "key.pem").unlink(missing_ok=True)
            temp_path.rmdir()

[tylern4]

Ah okay makes sense!

[cjh1]

LGTM, thanks for making the updates.