Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an existing access token to be used with client #79

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

cjh1
Copy link
Collaborator

@cjh1 cjh1 commented Jul 30, 2024

This PR refactors the way we create a http client to make api calls. This is done to allow the use of an existing access token when creating a client, an example of this use case would be calling api from within a REST endpoint, where you already have a valid access token.

@cjh1 cjh1 requested a review from tylern4 July 30, 2024 17:58
Copy link
Member

@tylern4 tylern4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like that it removes some repeated code and puts the headers logic in one place. LGTM!

@cjh1 cjh1 merged commit 7fb4175 into main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants