Migrated tests and pages from blueprint and removed example tests #2
Conversation
| homepage.click_refresh_alerts_link() | ||
| # Verify that the 'last updated' timestamp matches the current date and time | ||
| (expect(page.locator("form[name=\"refreshCockpit\"]")).to_contain_text | ||
| ("Refresh alerts (last updated :" + DateTimeUtils.current_datetime())) |
There was a problem hiding this comment.
I would amend this to f"Refresh alerts (last updated : {DateTimeUtils.current_datetime()})"
|
|
||
| def test_login_to_bcss_with_invalid_username(page: Page) -> None: | ||
| username = "BCSSZZZ" | ||
| password = "changeme" |
There was a problem hiding this comment.
We need to remove this secret and pass it into the code
| expect(page.locator("b")).to_contain_text(report_timestamp) | ||
|
|
||
| # Open an appointment record from the report | ||
| page.get_by_role("link", name="934 9288").click() |
There was a problem hiding this comment.
This looks like an NHS number so we'd need to change the locator to be more generic
| def login_as_user_bcss401(self): | ||
| """Logs in to bcss as the test user 'BCSS401'""" | ||
| self.username.fill("BCSS401") | ||
| self.password.fill("changeme") |
There was a problem hiding this comment.
We need to remove this as it's a secret and pass it in - it might also be worth us importing the user util from the blueprint to manage the account access
There was a problem hiding this comment.
In the bcss-playwright repo I have removed the login_as_user function and pass in the login info from an environmental variable in the test itself, this can either be loaded in from a dotenv file (.env) or if run in a pipeline have the values injected from a secret.
it looks like this:
load_dotenv()
expect.set_options(timeout=30_000)
@pytest.fixture(scope="function", autouse=True)
def before_each(page: Page):
# This will run before every other job and log in to the homepage.
username = environ.get("BCSS_USERNAME")
password = environ.get("BCSS_PASSWORD")
login_page = BcssLoginPage(page)
login_page.login(username, password)There was a problem hiding this comment.
That make sense for the password and I very much like the way that's been done because it's nice and clean, but passing in the username in the same fashion could be problematic once we've got a bunch of tests focusing on different areas of the system, and because BCSS is complex we often require multiple users to achieve the end result. I'd be inclined to do this logic for passwords but maintain the users in the code directly, more from a maintenance standpoint.
Changed the dropdown option value numbers in the functions to class variables.
…ub.com:NHSDigital/bcss-playwright into feature/migrate_tests_and_utils_from_blueprint
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.