Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Module and Example #29

Merged
merged 13 commits into from
Aug 8, 2024
Merged

Files Module and Example #29

merged 13 commits into from
Aug 8, 2024

Conversation

a-l-holmes
Copy link
Collaborator

Motivation

Creation of logical model, profile, and example for the "File" attribute of the IG.

Approach

Generate FSH code with examples from Participant, Research Study, and Family already in the NCPI FHIR IG 2 to make the existing DocumentReference profile hold all the attributes we need.

@github-actions github-actions bot temporarily deployed to pull request July 30, 2024 19:13 Inactive
Copy link

github-actions bot commented Jul 30, 2024

🚀 IG Site Preview Deployed

Latest commit: f12a301

View deployment

@a-l-holmes a-l-holmes linked an issue Jul 30, 2024 that may be closed by this pull request
Closed
3 tasks
@a-l-holmes a-l-holmes requested a review from torstees July 31, 2024 12:24
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a info for the actual profile? Here is what the participant one looks like: https://github.com/NIH-NCPI/ncpi-fhir-ig-2/blob/main/input/pagecontent/StructureDefinition-ncpi-participant-intro.md

Important parts are Key Guidelines and FHIR Mappings. Feel free to ask questions if you aren't sure what filename to use, or if your table ends up wonky.

Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the -notes.md files aren't showing up in the profiles and LM pages, but we need to figure that out. Also, could you update the FHIR Mappings on the profile's notes page?

@github-actions github-actions bot temporarily deployed to pull request August 7, 2024 15:42 Inactive
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple issues left, but it's getting very close.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename here is slightly different from what is expected by the publisher application. It should be StructureDefinition-SahredDataModelFile-intro.md based on the id of your logical model. When you change this filename, the content here should magically appear inside your logical model.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch-- I made the change in the file name!

| **Logical Model Property** | **Cardinality** | **NCPI FHIR Mapping** | **Usage Guidance** | **Notes**|
participantID|1..1|identifier.value|The participant(s) for whom this file contains data|
fileExternalID|0..1|subject|A related identifier of this file|
format|1..1|codextension[file-format].valueCodeableConcept.codinge|The file format used|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect "codextension" is not what you meant to use here.

@github-actions github-actions bot temporarily deployed to pull request August 8, 2024 12:15 Inactive
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. We should revisit those TODOs once we work on the metadata part (i.e. if the solution isn't relevant here, then remove them when they end up in the new metadata structure, whatever that ends up being). I think having them here as placeholders for something on the immediate horizon is probably helpful if the metadata isn't ready by that meeting.

@a-l-holmes a-l-holmes merged commit ccfbfc5 into main Aug 8, 2024
2 checks passed
@a-l-holmes a-l-holmes deleted the files_module branch August 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File
2 participants