-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files Module and Example #29
Conversation
🚀 IG Site Preview DeployedLatest commit: f12a301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a info for the actual profile? Here is what the participant one looks like: https://github.com/NIH-NCPI/ncpi-fhir-ig-2/blob/main/input/pagecontent/StructureDefinition-ncpi-participant-intro.md
Important parts are Key Guidelines and FHIR Mappings. Feel free to ask questions if you aren't sure what filename to use, or if your table ends up wonky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the -notes.md files aren't showing up in the profiles and LM pages, but we need to figure that out. Also, could you update the FHIR Mappings on the profile's notes page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple issues left, but it's getting very close.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename here is slightly different from what is expected by the publisher application. It should be StructureDefinition-SahredDataModelFile-intro.md based on the id of your logical model. When you change this filename, the content here should magically appear inside your logical model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch-- I made the change in the file name!
| **Logical Model Property** | **Cardinality** | **NCPI FHIR Mapping** | **Usage Guidance** | **Notes**| | ||
participantID|1..1|identifier.value|The participant(s) for whom this file contains data| | ||
fileExternalID|0..1|subject|A related identifier of this file| | ||
format|1..1|codextension[file-format].valueCodeableConcept.codinge|The file format used| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect "codextension" is not what you meant to use here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. We should revisit those TODOs once we work on the metadata part (i.e. if the solution isn't relevant here, then remove them when they end up in the new metadata structure, whatever that ends up being). I think having them here as placeholders for something on the immediate horizon is probably helpful if the metadata isn't ready by that meeting.
Motivation
Creation of logical model, profile, and example for the "File" attribute of the IG.
Approach
Generate FSH code with examples from Participant, Research Study, and Family already in the NCPI FHIR IG 2 to make the existing DocumentReference profile hold all the attributes we need.