Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module review #44

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Module review #44

merged 3 commits into from
Aug 22, 2024

Conversation

a-l-holmes
Copy link
Collaborator

Motivation

Review of all modules for alignment to the Codeathon documents outlining how we wanted to execute each resource

Approach

Combed through looking for issues in cardinality mainly or other expectations for mappings

@a-l-holmes a-l-holmes requested a review from torstees August 22, 2024 14:35
@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 14:39 Inactive
Copy link

github-actions bot commented Aug 22, 2024

🚀 IG Site Preview Deployed

Latest commit: ec58e62

View deployment

Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could change that one identifier's cardinality to 1..*, then this will be perfect!

@github-actions github-actions bot temporarily deployed to pull request August 22, 2024 16:21 Inactive
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@a-l-holmes a-l-holmes merged commit a7f12c0 into main Aug 22, 2024
2 checks passed
@a-l-holmes a-l-holmes deleted the module-review branch August 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants