Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributors Page #15

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

gutsytechster
Copy link
Contributor

@gutsytechster gutsytechster commented Dec 5, 2018

Closes #3

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  1. Does your submission pass build tests locally?
  2. Have you indented your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Hope that you have followed the contribution guidelines :-)

(Powered by GitMate.io)

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Include the screenshots with a brief description in the PR comment itself . Look at #10 for suggestions how to do it

@gutsytechster
Copy link
Contributor Author

contributorpage

@gutsytechster
Copy link
Contributor Author

Hey, here is the screenshot.
All the contributor's name are clickable and forward to their github account.

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Great job! @gutsytechster . Could you make it a bit more appealing by viewing the profile pics as well. Something like this
contri

@gutsytechster
Copy link
Contributor Author

Sure

@gutsytechster
Copy link
Contributor Author

modified

@monsij
Copy link
Member

monsij commented Dec 5, 2018

good job @gutsytechster . 💯

@monsij
Copy link
Member

monsij commented Dec 5, 2018

"@gitmate-bot rebase"

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@monsij
Copy link
Member

monsij commented Dec 5, 2018

Automated rebase with GitMate.io was successful! 🎉

@monsij
Copy link
Member

monsij commented Dec 5, 2018

ack 0fda4dc

@monsij monsij merged commit a1eb3c1 into NIT-DGPortal:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants