-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
584-allow uppercase in package name #613
Draft
fdiblen
wants to merge
3
commits into
main
Choose a base branch
from
584_package_name_regex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,13 +10,17 @@ | |||||
* Make contributing guidelines optional [#465](https://github.com/NLeSC/python-template/pull/465) | ||||||
* Make developer documentation optional [#467](https://github.com/NLeSC/python-template/pull/541) | ||||||
* Make Code of Conduct optional [#464](https://github.com/NLeSC/python-template/pull/530) | ||||||
* CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | ||||||
* pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* New YAML files for copier questions [#529](https://github.com/NLeSC/python-template/pull/529) | ||||||
* Make zenodo next step instructions optional [#520](https://github.com/NLeSC/python-template/pull/520) | ||||||
* Make SonarCloud optional [#515](https://github.com/NLeSC/python-template/pull/515) | ||||||
* Make citation optional [#471](https://github.com/NLeSC/python-template/pull/471) | ||||||
* Make online documentation optional [#476](https://github.com/NLeSC/python-template/pull/476) | ||||||
|
||||||
### Changed | ||||||
* Made copier configuration more modular [#529](https://github.com/NLeSC/python-template/pull/529) | ||||||
* Allow uppercase in package name [#613](https://github.com/NLeSC/python-template/pull/613) | ||||||
* next_steps.md is shown as a copier message [#609](https://github.com/NLeSC/python-template/pull/609) | ||||||
* Change the default profile to 'recommended' [#598](https://github.com/NLeSC/python-template/pull/598) | ||||||
* Updated the user documentation (README.md) of the template [#569](https://github.com/NLeSC/python-template/pull/569) | ||||||
|
@@ -33,7 +37,6 @@ | |||||
Released on August 15, 2024 | ||||||
|
||||||
### Added | ||||||
|
||||||
* Added Python 3.12 support [#356](https://github.com/NLeSC/python-template/issues/356) | ||||||
* Template unit tests for documentation generation, linting and version bumping | ||||||
* Docstring for function | ||||||
|
@@ -42,10 +45,6 @@ Released on August 15, 2024 | |||||
* Added new 'docs' section in extra dependencies [#317](https://github.com/NLeSC/python-template/issues/317) | ||||||
|
||||||
### Changed | ||||||
|
||||||
* Made copier configuration more modular [#529](https://github.com/NLeSC/python-template/pull/529) | ||||||
* pre-commit script is optional ([#457](https://github.com/NLeSC/python-template/issues/457)) | ||||||
* CHANGELOG.md is now optional ([#462](https://github.com/NLeSC/python-template/issues/462)) | ||||||
* Moved to src/ based layout for generated packages | ||||||
* Moved from setup.cfg/.py to pyproject.toml [#351](https://github.com/NLeSC/python-template/issues/351) | ||||||
* Moved from prospector to ruff [#336](https://github.com/NLeSC/python-template/issues/336) | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -5,7 +5,7 @@ package_name: | |||||
placeholder: my_python_package | ||||||
help: Enter the name of the Python package. | ||||||
validator: >- | ||||||
{% if not (package_name | regex_search('^[a-z][a-z0-9\_]+$')) %} | ||||||
{% if not (package_name | regex_search('^[A-Za-z][A-Za-z0-9\_]+$')) %} | ||||||
Package name must start with a letter, followed one or more letters, digits or underscores all lowercase | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
{% endif %} | ||||||
version: | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.