Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust unit tests to CI #378

Merged
merged 4 commits into from
May 22, 2024
Merged

Add Rust unit tests to CI #378

merged 4 commits into from
May 22, 2024

Conversation

felixhekhorn
Copy link
Contributor

@felixhekhorn felixhekhorn commented May 22, 2024

TODO:

  • revert TODO in workflow

@felixhekhorn felixhekhorn added benchmarks Benchmark (or infrastructure) related rust Rust extension related labels May 22, 2024
@felixhekhorn felixhekhorn marked this pull request as ready for review May 22, 2024 08:26
@felixhekhorn
Copy link
Contributor Author

Can someone of you have a quick look to this? by quick searching I found this repo to install Rust, but I wonder if that is too much and I should go back to straight install as done here - what do you think?

also I realized the poe commands don't need to go under the patch (only the true hoooking)

@felixhekhorn
Copy link
Contributor Author

Eventually I want to also add fmt and clippy, but as far as I understood that requires the packages top level and this will be realized after #375

@cschwan
Copy link

cschwan commented May 22, 2024

Can someone of you have a quick look to this? by quick searching I found this repo to install Rust, but I wonder if that is too much and I should go back to straight install as done here - what do you think?

The toolchain action is considered canonical as far as I know. I can't access the other link (It only shows 'Forbidden').

@felixhekhorn
Copy link
Contributor Author

Can someone of you have a quick look to this? by quick searching I found this repo to install Rust, but I wonder if that is too much and I should go back to straight install as done here - what do you think?

The toolchain action is considered canonical as far as I know. I can't access the other link (It only shows 'Forbidden').

thanks, so I assume it is fine

the other link said something like

- name: Update local toolchain
        run: |
          rustup update
          rustup component add clippy
          rustup install nightly 

.github/workflows/unittests-rust.yml Outdated Show resolved Hide resolved
pyproject.toml.patch Show resolved Hide resolved
@felixhekhorn felixhekhorn merged commit 2348778 into master May 22, 2024
7 checks passed
@felixhekhorn felixhekhorn deleted the rust-unittest branch May 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related rust Rust extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants