Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grouping default to new lockfile mechanism #1163

Closed
wants to merge 1 commit into from

Conversation

wilsonmr
Copy link
Contributor

Blocked by NNPDF/reportengine#41

Using the redux to apply default grouping. Added some tests to make sure it works as intended - these will of course fail until that PR is merged (unless you have dev install of reportengine)

cc: @siranipour

@wilsonmr wilsonmr marked this pull request as draft March 24, 2021 10:15
@wilsonmr
Copy link
Contributor Author

I don't foresee any issues but I want to run a comp fits report on this branch just to make sure.

@wilsonmr
Copy link
Contributor Author

I've removed the mapping here for the default grouping because in the end this is a fallback default which I don't think we need more than one value for. Originally we wanted to potentially allow for a different default for, say, theory covariance reports however the point is that specifying that you want a different default in this case is just as much effort (and more confusing) that explicitly stating the grouping you want or using the fixed grouping production rules (i.e produce_group_dataset_inputs_by_process)

@siranipour
Copy link
Contributor

Do we reckon there is much left in NNPDF/reportengine#41

@wilsonmr
Copy link
Contributor Author

I think the point is to check that this looks ok and maybe at least make a template for dataset defaults to see how that will work before merging that - side note I also need to fix the tests there.

I thought I should at least minimally do this part.

@siranipour
Copy link
Contributor

Just rebasing this onto master to build on it in another PR

@scarlehoff
Copy link
Member

Closing this since NNPDF/reportengine#41 has been stale for more than two years now :(

@scarlehoff scarlehoff closed this Mar 14, 2023
@scarlehoff scarlehoff deleted the group-defaults branch March 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants