-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique log files for each mongo worker #2016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Cmurilochem for this. This would be useful indeed to know what happened during a trial.
9b2fb60
to
11f9155
Compare
11f9155
to
4bdcca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again.
Thanks @Radonirinaunimi. Not sure if @RoyStegeman wants to have a look at it, but if not, could you merge it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Cmurilochem! This looks good to me as well, feel free to merge after making these changes. If you agree with them of course
Co-authored-by: Roy Stegeman <[email protected]>
Co-authored-by: Roy Stegeman <[email protected]>
Thanks @RoyStegeman. Suggestions accepted. It seems that I am not authorized to merge this PR. Please, could you do that ? |
Ah, I hadn't realised you were not registered as a member of this organisation |
Aim
Allow mongo workers to write output data to separate files.
Idea
Redirect the output of each subprocess.Popen to unique log files (
stdout
) for each mongo worker. These files are namedmongo-worker_n_output_path.log
, wheren=0, 1, 2, ..., n
is the unique id of the worker andoutput_path
corresponds to the runcard name orOUTPUT
ifn3fit -o OUTPUT
was used.Notes/Drawbacks
The
mongo-worker_n_output_path.log
files will only contain data output by any function/method called byfmin
, i.e., by ModelTrainer.hyperparametrizable which consists of details of the hyperparameters being evaluated and info about epochs. Other infos and warnings are still printed to standard output (screen), including trial numbers which might not be ideal.Either way, it appears that with this simple change we can prevent the overwhelming/chaotic information that was previously displayed on the screen.
Tasks
stdout
redirection files tostart_mongo_workers
Popen.