Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the square_singlet activation function #2064

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

scarlehoff
Copy link
Member

With a check so that it can only be used as the final layer.

@scarlehoff scarlehoff requested a review from RoyStegeman April 25, 2024 13:42
@RoyStegeman
Copy link
Member

Ah wait, this is applied before the basis rotation so maybe a check should be added that you're indeed squaring the singlet elements?

@scarlehoff
Copy link
Member Author

I can add that, yes.
That would make it not work if one uses something like the flavour basis, but that's probably a good thing.

@scarlehoff
Copy link
Member Author

@RoyStegeman can I take the previous green tick as still applying?

This has been used for this fit: https://vp.nnpdf.science/TsABd61tS_OOMbRYxCcmlA==/

@RoyStegeman
Copy link
Member

RoyStegeman commented May 7, 2024

This has been used for this fit: https://vp.nnpdf.science/TsABd61tS_OOMbRYxCcmlA==/

Did you also check in evol basis? Since there it's easier to see the impact of this activation function

@scarlehoff
Copy link
Member Author

What do you mean? It can only be used in the evolution basis.

@RoyStegeman
Copy link
Member

But the plots in the report are all flavor basis, so they don't really help to see if this PR does what you want

Copy link
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the checks

@scarlehoff
Copy link
Member Author

so they don't really help to see if this PR does what you want

Ah! That's what you mean. Yes: https://vp.nnpdf.science/RqocL3BvSL698F2-3ytrAw==/Scales0_pdf_report_report.html#Scales0_pdf_report_PDFnormalize0_Basespecs1_PDFscalespecs1_plot_pdfs_Sigma

(although it only makes a real difference for the gluon tbh)

@RoyStegeman
Copy link
Member

Thanks, I'm happy to merge

@scarlehoff scarlehoff merged commit 124ae08 into master May 7, 2024
6 checks passed
@scarlehoff scarlehoff deleted the square_singlet branch May 7, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants