-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the square_singlet activation function #2064
Conversation
Ah wait, this is applied before the basis rotation so maybe a check should be added that you're indeed squaring the singlet elements? |
I can add that, yes. |
@RoyStegeman can I take the previous green tick as still applying? This has been used for this fit: https://vp.nnpdf.science/TsABd61tS_OOMbRYxCcmlA==/ |
Did you also check in evol basis? Since there it's easier to see the impact of this activation function |
What do you mean? It can only be used in the evolution basis. |
But the plots in the report are all flavor basis, so they don't really help to see if this PR does what you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the checks
Ah! That's what you mean. Yes: https://vp.nnpdf.science/RqocL3BvSL698F2-3ytrAw==/Scales0_pdf_report_report.html#Scales0_pdf_report_PDFnormalize0_Basespecs1_PDFscalespecs1_plot_pdfs_Sigma (although it only makes a real difference for the gluon tbh) |
Thanks, I'm happy to merge |
With a check so that it can only be used as the final layer.