Hashable Rules #2076
Hashable Rules #2076
Conversation
There was a problem hiding this comment.
Thanks for this, could you also remove frozenargs from the conda recipe / pyproject? It should not be needed anymore
(I think this closes #2027 ^^)
I am not sure I understand, do you mean |
I thought it was only needed by the filter rules? |
| @@ -511,7 +558,7 @@ def __init__(self, initial_data: dict, *, defaults: dict, theory_parameters: dic | |||
| self.rule_string = self.rule | |||
| self.defaults = defaults | |||
| self.theory_params = theory_parameters | |||
| ns = {*self.numpy_functions, *self.defaults, *self.variables, "idat", "central_value"} | |||
| ns = {*self.numpy_functions, *self.defaults.to_dict().keys(), *self.variables, "idat", "central_value"} | |||
There was a problem hiding this comment.
| ns = {*self.numpy_functions, *self.defaults.to_dict().keys(), *self.variables, "idat", "central_value"} | |
| ns = {*self.numpy_functions, *self.defaults.to_dict(), *self.variables, "idat", "central_value"} |
Not that it makes a difference though.
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
Co-authored-by: Juan M. Cruz-Martinez <[email protected]>
|
|
||
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class AddedFilterRule(FilterRule): |
There was a problem hiding this comment.
What is the purpose of this class?
Rules (for cuts) are made to tuple instead of list.
This makes them hashable and allows eg them to contained within a
TupleCompobject