Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute new commondata generation in CI #2099

Merged
merged 26 commits into from
Nov 2, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8767b61
init CI to check new commondata
Radonirinaunimi Jun 4, 2024
2d1d9cb
add pandas and numpy as dependencies to nnpdf_data
Radonirinaunimi Jun 4, 2024
306db71
fail with exit during some events
Radonirinaunimi Jun 5, 2024
411c932
add uproot as a dependency of the nnpdf data
Radonirinaunimi Jun 21, 2024
5aa3c9d
fix some stupid missing line
Radonirinaunimi Jun 21, 2024
b4d7b13
Merge branch 'master' into check_newcd
Radonirinaunimi Jul 17, 2024
6c53d9a
attempt first not to fail when there are changed files
Radonirinaunimi Jul 17, 2024
7271ab5
move TOPO_DEF to main poldata utils
Radonirinaunimi Jul 17, 2024
f258acb
Merge branch 'master' into check_newcd
Radonirinaunimi Jul 30, 2024
21059df
re-generate new commondata
Radonirinaunimi Jul 30, 2024
ad7ce9a
merge changes from master
Radonirinaunimi Oct 24, 2024
8b9d58e
Fix imports of `TOP_DEF` in STAR experiments
Radonirinaunimi Oct 24, 2024
06c19b5
Fain only after listing the changed files
Radonirinaunimi Oct 24, 2024
ce333b0
Add `YAML.pretiffier` for datasets with `filter.py`
Radonirinaunimi Oct 25, 2024
dd2c381
Merge branch 'master' into check_newcd
scarlehoff Nov 1, 2024
8a27d30
Update fitbot.yml
scarlehoff Nov 1, 2024
69f42f4
Update check_newcd.yml
scarlehoff Nov 1, 2024
8512ddf
Fix Yaml dumping of the EIC Pseudodata
Radonirinaunimi Nov 1, 2024
fbe9d97
Try if this fixes the CMS uncs (using `numpy-2.1.2`)
Radonirinaunimi Nov 1, 2024
9278cd4
update files from ubuntu
scarlehoff Nov 1, 2024
8d951a6
A separate `CI` to re-generate the commondata?
Radonirinaunimi Nov 1, 2024
3536ea0
Add `user.email` to `regenerate_data` CI
Radonirinaunimi Nov 1, 2024
b3543c3
Fix stupid mistake (need to checkout branch first)
Radonirinaunimi Nov 1, 2024
5f5d1cf
Automatically regenerated commondata from PR 2099, branch check_newcd.
Nov 1, 2024
bac4a93
Simply trigger all the tests
Radonirinaunimi Nov 1, 2024
f5b0de0
Update fitbot.yml
scarlehoff Nov 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/check_newcd.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# A CI script with github workflow to test the new commondata
name: Test new commondata

on:
push:
workflow_dispatch:

jobs:
test-commondata:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
fetch-tags: true
fetch-depth: 0
- name: Install NNPDF data package 🐍
run: pip install ./nnpdf_data/'[filter]'
- name: Run the filters 📦
shell: bash -l {0}
run: |
here=$PWD
readarray -d '' array < <(find ./nnpdf_data/nnpdf_data/new_commondata -name "filter.py" -print0)
for datname in "${array[@]}"; do dirpath=${datname%/*}; cd $dirpath; python filter.py || exit $?; cd $here; done
- name: Check for modified files 🛎️
uses: tj-actions/verify-changed-files@v20
id: verify-changed-files
with:
fail-if-changed: "false"
- name: List all changed tracked and untracked files 🛎️
env:
CHANGED_FILES: ${{ steps.verify-changed-files.outputs.changed_files }}
run: |
echo "Changed files: $CHANGED_FILES"
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@
import pandas as pd
import yaml

# Definition of various topologies used in Polarized Dijets
# NOTE: the observable is symmetric for jet1 and jet2,
# so 1 and 2 are not ordered in pT.
TOPO_DEF = {
"A": {"abs_eta1_min": 0.3, "abs_eta1_max": 0.9, "abs_eta2_min": 0.3, "abs_eta2_max": 0.9},
"B": {"abs_eta1_min": 0, "abs_eta1_max": 0.3, "abs_eta2_min": 0.3, "abs_eta2_max": 0.9},
"C": {"abs_eta1_min": 0, "abs_eta1_max": 0.3, "abs_eta2_min": 0, "abs_eta2_max": 0.3},
"D": {"abs_eta1_min": 0.3, "abs_eta1_max": 0.9, "abs_eta2_min": 0.3, "abs_eta2_max": 0.9},
"I": {"abs_eta_min": 0, "abs_eta_max": 0.9},
}


def read_central_values(path: Path) -> np.ndarray:
"""Read the central values from the theory predictions.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from nnpdf_data.filter_utils.eic_utils import (
from nnpdf_data.filter_utils.poldata_utils import (
fluctuate_data,
read_central_values,
read_excel,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from nnpdf_data.filter_utils.eic_utils import read_excel, write_data
from nnpdf_data.filter_utils.poldata_utils import read_excel, write_data

np.random.seed(1234567890)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from nnpdf_data.filter_utils.eic_utils import (
from nnpdf_data.filter_utils.poldata_utils import (
fluctuate_data,
read_central_values,
read_excel,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from nnpdf_data.filter_utils.eic_utils import (
from nnpdf_data.filter_utils.poldata_utils import (
fluctuate_data,
read_central_values,
read_excel,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import numpy as np

from nnpdf_data.filter_utils.eic_utils import (
from nnpdf_data.filter_utils.poldata_utils import (
fluctuate_data,
read_central_values,
read_excel,
Expand Down
Loading