-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implementation of CMS single top #2200
Conversation
Following up on @scarlehoff suggestion in PR#2185 to compare the overall experimental chi2 with all datasets combined, I'm attaching here the reports: Regarding the ordering, for each dataset, legacy always appears first and is followed by the new commondata implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please, bump the version number and change the version comment just like in the ATLAS one.
Although, I think you forgot to add some of the filter.py
files?
(btw, like in the ATLAS pr, rebase on top of master please)
nnpdf_data/nnpdf_data/commondata/CMS_SINGLETOP_13TEV/metadata.yaml
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,33 @@ | |||
meta: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove this runcard from here (maybe put in the PR for reference)
(it will be eventually removed alongside all the rawdata anyway)
8bfe593
to
3f4e62d
Compare
Hi @scarlehoff , also this PR should be ready for merging once the tests pass. The reason some of the filter scripts aren't there is because there's no HEPdata entry for those datasets. Final validphys report can be found at https://vp.nnpdf.science/2txronVJRuG9xBFIOjwPWQ==/ |
3f4e62d
to
327ca7f
Compare
This PR reimplements CMS single top. All datasets agree with the legacy implementation.
All metadata has been updated accordingly.