Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover 3.9 test #2257

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Recover 3.9 test #2257

merged 1 commit into from
Jan 15, 2025

Conversation

scarlehoff
Copy link
Member

Let's recover the 3.9 test. Perhaps we need to skip the regression tests for 3.9 but that's fine.

@scarlehoff
Copy link
Member Author

@RoyStegeman if you don't have anything against this, I'll merge?

RoyStegeman
RoyStegeman approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@RoyStegeman RoyStegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. I think we never tested 3.9 in the python installation, only in the conda one (but that wasn't really testing 3.9 as we discovered)

@scarlehoff scarlehoff merged commit 84f6be4 into master Jan 15, 2025
9 checks passed
@scarlehoff scarlehoff deleted the scarlehoff-patch-1 branch January 15, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyStegeman RoyStegeman RoyStegeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarlehoff @RoyStegeman