Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mu0 according to Q0 #147

Merged
merged 2 commits into from
Dec 18, 2023
Merged

fix mu0 according to Q0 #147

merged 2 commits into from
Dec 18, 2023

Conversation

giacomomagni
Copy link
Contributor

Solve #146

@giacomomagni giacomomagni added the bug Something isn't working label Dec 15, 2023
@felixhekhorn
Copy link
Contributor

  • 8a87621 adds a unit test
  • banana has become a test dependency, because I want the theory card from there
  • following the spirit of test_write_operator_card_q0 the whole write_operator_card should be tested as the function is rather complicated and doing several things simultaneously cc @andreab1997

@giacomomagni
Copy link
Contributor Author

Thanks @felixhekhorn for adding the test. Shall I merge?

@giacomomagni giacomomagni linked an issue Dec 15, 2023 that may be closed by this pull request
mu0 scale is not updated correctly in the operator cards. #146
Closed
@felixhekhorn
Copy link
Contributor

fine by me (maybe @andreab1997 wants to have a look?)

@giacomomagni giacomomagni changed the title fix mu0 accordying to Q0 fix mu0 according to Q0 Dec 15, 2023
@giacomomagni giacomomagni merged commit 3e8ddc8 into main Dec 18, 2023
5 checks passed
@giacomomagni giacomomagni deleted the fix_mu0_template branch March 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreab1997 andreab1997 andreab1997 approved these changes

@Radonirinaunimi Radonirinaunimi Radonirinaunimi approved these changes

@felixhekhorn felixhekhorn felixhekhorn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mu0 scale is not updated correctly in the operator cards.
4 participants
@giacomomagni @felixhekhorn @Radonirinaunimi @andreab1997