Skip to content

Commit

Permalink
Bugfix for ensemble update: rollback changes in gdas_ens_handler (#1430)
Browse files Browse the repository at this point in the history
# Description

Bugfix for #1429.
I am rolling back the change in `gdas_ens_handler` from
#1417 that resulted in ensemble
increments missing ssh which is used (at least to check dimensions) in
mom6 IAU. From looking at the original PR I don't think this change was
intentional, and I _think_ it's OK to roll it back, although it would be
good if someone with the knowledge of this workflow can review.

# Issues

Fixes #1429

Co-authored-by: Anna Shlyaeva <[email protected]>
  • Loading branch information
shlyaeva and Anna Shlyaeva authored Jan 6, 2025
1 parent 322ce42 commit c665ec9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions utils/soca/gdas_ens_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,14 @@ namespace gdasapp {
oops::Log::info() << "recentered incr " << i << ":" << incr << std::endl;

// Append the vertical geometry (for MOM6 IAU)
postProcIncr.appendLayer(incr);
oops::Log::info() << "incr " << i << ":" << incr << std::endl;
soca::Increment mom6_incr = postProcIncr.appendLayer(incr);
oops::Log::info() << "incr " << i << ":" << mom6_incr << std::endl;

// Set variables to zero if specified in the configuration
postProcIncr.setToZero(incr);

// Save the increments used to initialize the ensemble forecast
result = postProcIncr.save(incr, i+1);
result = postProcIncr.save(mom6_incr, i+1);
}
return result;
}
Expand Down

0 comments on commit c665ec9

Please sign in to comment.