Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ocean basin flag to all converters #775

Closed
guillaumevernieres opened this issue Nov 28, 2023 · 1 comment · Fixed by #821
Closed

Add the ocean basin flag to all converters #775

guillaumevernieres opened this issue Nov 28, 2023 · 1 comment · Fixed by #821
Assignees
@apchoiCMD
Labels
soca

Comments

@guillaumevernieres
Copy link
Contributor

See PR#732.
@apchoiCMD
Copy link
Collaborator

apchoiCMD commented Dec 20, 2023 •
edited
Loading

Example for Ocean Basin Flag: One full Obs files are used for each plot

ocean_flag_combined

@apchoiCMD apchoiCMD mentioned this issue Dec 20, 2023
Merged
guillaumevernieres pushed a commit that referenced this issue Dec 21, 2023
@apchoiCMD
Adding a feature Metadata/ocean-basin-flag to all ioda converters (#821)
116da71 
- Moved a simple OceanMask struct that reads in regional ocean masks to
base class
- Those are an implementation of the feature in all converters

Close #775

- Tested with one full obs file for each converter:

![ocean_flag_combined](https://github.com/NOAA-EMC/GDASApp/assets/141867620/e114f1c4-f45a-420e-8336-26075cdfa301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apchoiCMD apchoiCMD

Labels
soca
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a feature Metadata/ocean-basin-flag to all ioda converters NOAA-EMC/GDASApp
2 participants
@guillaumevernieres @apchoiCMD