Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a feature Metadata/ocean-basin-flag to all ioda converters #821

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Adding a feature Metadata/ocean-basin-flag to all ioda converters #821

merged 2 commits into from
Dec 21, 2023

Conversation

apchoiCMD
Copy link
Collaborator

  • Moved a simple OceanMask struct that reads in regional ocean masks to base class
  • Those are an implementation of the feature in all converters

Close #775

  • Tested with one full obs file for each converter:
    ocean_flag_combined

guillaumevernieres
guillaumevernieres approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apchoiCMD , looks good.

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Dec 20, 2023
ShastriPaturi
ShastriPaturi approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apchoiCMD for putting this effort.
Much appreciated.

@apchoiCMD
Copy link
Collaborator Author

apchoiCMD commented Dec 20, 2023 •
edited
Loading

Thanks @apchoiCMD for putting this effort. Much appreciated.

Thank you to both @guillaumevernieres and @ShastriPaturi for your patience! I couldn't make it without your support.

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 20, 2023
@emcbot
Copy link

emcbot commented Dec 20, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Dec 20 22:07:31 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec 20 23:00:23 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Dec 20 23:30:50 UTC 2023
Tests: 85% tests passed, 8 tests failed out of 55
	1341 - test_gdasapp_util_prepdata (Failed)
	1705 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/821/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 20, 2023
@guillaumevernieres guillaumevernieres merged commit 116da71 into develop Dec 21, 2023
11 checks passed
@apchoiCMD apchoiCMD deleted the feature/ioda-ocean-basin branch February 5, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShastriPaturi ShastriPaturi ShastriPaturi approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ocean basin flag to all converters
4 participants
@apchoiCMD @emcbot @guillaumevernieres @ShastriPaturi