Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tostring(pkgVersion) to select GDAS modulefiles #1422

Closed
wants to merge 1 commit into from

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 19, 2024

Description

This PR modifies select machine modulefiles in modulefiles/GDAS to allow them to be loaded via

  • module use ${path}/modulefiles/GDAS
  • module load ${machine}.${comp}

Companion PRs

none

Issues

Resolves #1418

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA changed the title add tostring(pkgVersion) to select GDAS modulefiles (#1418) add tostring(pkgVersion) to select GDAS modulefiles Dec 19, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

The true problem is that myModuleVersion() returns the Boolean value false. This is accurate because the modulefile does not define a version. Converting Boolean value false to a string via tostring() is not the correct solution.

Close this PR until a proper solution is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question on building gdasapp on orion
1 participant