Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ctests #1425

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Bugfix/ctests #1425

merged 2 commits into from
Dec 23, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 21, 2024 •
edited
Loading

Description

The PR updates

  1. test/atm/global-workflow/jjob_ens_init_split.sh
  2. test/gw-ci/CMakeLists.txt

so that select ctests run on more machines (change 1) or run more reliably (change 2).

The change to jjob_ens_init_split.sh resolves a link error on Orion. The change to CMakeLists.txt updates g-w job dependencies to ensure certain CI streams properly sequence jobs.

An additional change to jjob_ens_init_split.sh gives the job log file a unique name to distinguish it from jjobs_ens_init.sh

Companion PRs

None

Issues

Resolves #1424

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Dec 21, 2024
@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Dec 21, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 21, 2024
@emcbot
Copy link

emcbot commented Dec 21, 2024

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Sat Dec 21 19:54:18 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Dec 21 20:41:10 UTC 2024
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Sat Dec 21 21:49:30 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 115

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 21, 2024
DavidNew-NOAA
DavidNew-NOAA approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@RussTreadon-NOAA RussTreadon-NOAA merged commit be0cf45 into develop Dec 23, 2024
14 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/ctests branch December 23, 2024 14:27
@DavidNew-NOAA DavidNew-NOAA mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNew-NOAA DavidNew-NOAA DavidNew-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_gdasapp failures
3 participants
@RussTreadon-NOAA @emcbot @DavidNew-NOAA