Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JEDI hashes #1437

Merged
merged 15 commits into from
Jan 10, 2025
Merged

Update JEDI hashes #1437

merged 15 commits into from
Jan 10, 2025

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jan 9, 2025 •
edited
Loading

Description

This PR updates JEDI hashes in sorc/

Companion PRs

none

Issues

Resolves #1436

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jan 9, 2025
@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 9, 2025
@RussTreadon-NOAA
Copy link
Contributor Author

Will mark this PR as Ready for review upon successful completion of automated hera-GW-RT

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 9, 2025
@emcbot
Copy link

emcbot commented Jan 9, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Thu Jan  9 12:37:07 UTC 2025 on hfe01
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan  9 13:25:14 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jan  9 13:26:00 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 9, 2025
@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jan 9, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 9, 2025
@emcbot
Copy link

emcbot commented Jan 9, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Thu Jan  9 13:57:25 UTC 2025 on hfe06
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan  9 14:46:13 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Thu Jan  9 16:05:31 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 134

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 9, 2025
@RussTreadon-NOAA
Copy link
Contributor Author

All GDASApp ctests, including g-w tests, pass on Hera. This PR is ready for review.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review January 9, 2025 16:14
shlyaeva
shlyaeva previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RussTreadon-NOAA !

DavidNew-NOAA
DavidNew-NOAA previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI tests pass. Approve. Thank you @RussTreadon-NOAA

@RussTreadon-NOAA
Copy link
Contributor Author

ci/stable_driver.sh runs nightly on Hera. The 20250110 run updated the hash for sorc/ufo. All 134 ctests passed and so feature/stable-nightly was updated to de44d65. This dismissed approvals for this PR.

@DavidNew-NOAA , can you reapprove?

@RussTreadon-NOAA RussTreadon-NOAA merged commit 614c7b6 into develop Jan 10, 2025
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/stable-nightly branch January 10, 2025 14:28
@RussTreadon-NOAA RussTreadon-NOAA restored the feature/stable-nightly branch January 10, 2025 14:29
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/stable-nightly branch January 10, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNew-NOAA DavidNew-NOAA DavidNew-NOAA approved these changes

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@shlyaeva shlyaeva shlyaeva left review comments

@guillaumevernieres guillaumevernieres Awaiting requested review from guillaumevernieres

@danholdaway danholdaway Awaiting requested review from danholdaway

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update JEDI hashes
5 participants
@RussTreadon-NOAA @emcbot @CoryMartin-NOAA @shlyaeva @DavidNew-NOAA