Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meanioda example now that timeWindow has been added #673

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix meanioda example now that timeWindow has been added #673

merged 2 commits into from
Oct 11, 2023

Conversation

CoryMartin-NOAA
Copy link
Contributor

See above. Fixes #672

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Oct 11, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Oct 11, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Oct 11, 2023
guillaumevernieres
guillaumevernieres approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CoryMartin-NOAA

@emcbot
Copy link

emcbot commented Oct 11, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Oct 11 14:49:38 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 11 15:59:58 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Oct 11 16:28:18 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 56

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Oct 11, 2023
@CoryMartin-NOAA CoryMartin-NOAA merged commit f57c1dc into develop Oct 11, 2023
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/ioda branch October 11, 2023 16:29
@emcbot
Copy link

emcbot commented Oct 11, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Oct 11 09:48:00 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Oct 11 11:06:24 CDT 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Oct 11 11:34:31 CDT 2023
Tests: 100% tests passed, 0 tests failed out of 56

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Oct 11, 2023
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not proficient in c++ but the changes make sense. Clone and build bugfix/ioda on Orion.

@CoryMartin-NOAA , your CI tests completed before my build and ctests completed. Even though the PR has been merged, I'll record my approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNew-NOAA DavidNew-NOAA DavidNew-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The build is failing in gdas_meanioda.h.
5 participants
@CoryMartin-NOAA @emcbot @guillaumevernieres @RussTreadon-NOAA @DavidNew-NOAA