Feature/nick e sfcshp prepbufr #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
height, var changes
nicholasesposito
added
the
documentation
nicholasesposito
requested review from
CoryMartin-NOAA,
PraveenKumar-NOAA,
emilyhcliu and
ADCollard
CoryMartin-NOAA
previously approved these changes
Nov 2, 2023
|
@nicholasesposito can you resolve the conflicts now that your other PR is merged? |
nicholasesposito
dismissed stale reviews from PraveenKumar-NOAA and CoryMartin-NOAA
via
9787950
|
@CoryMartin-NOAA resolved! |
CoryMartin-NOAA
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SFCSHP prepbufr updated api to the GDASApp.
The two files added are:
~/ush/ioda/bufr2ioda/bufr2ioda_sfcshp_prepbufr.py
~/parm/ioda/bufr2ioda/bufr2ioda_sfcshp_prepbufr.json
This is validated in ioda-converters issue 1293
I can open a JEDI-T20 issue for the validation if that is needed.