GHRSST bug fix ... an more

[guillaumevernieres]

Quite a few bug fixes, but the sstdtime is still not correct.

I added a feature in the testing so our ctest for GHRSST does more than just checking if things run without crashing! The GHRSST application outputs a few basic stats from the ioda variables:

Reading ghrsst_sst_mb_202107010000.nc4
obsVal:
    Min: 276.708
    Max: 276.9
    Sum: 4982.63
obsError:
    Min: 0.32
    Max: 0.32
    Sum: 5.76
...

See file below.
Still not enough but better than doing nothing!

[apchoiCMD]

Thanks @guillaumevernieres I will test it on hpc

[ShastriPaturi]

ctest passes

[guillaumevernieres]

Thanks @guillaumevernieres I will test it on hpc

Can I assume you approved because you tested on hpc @apchoiCMD ?

[apchoiCMD]

Yes, it was tested and all are passed. @guillaumevernieres sorry for the late reply!

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Nov 13 23:04:23 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Nov 13 23:51:27 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Nov 14 00:15:23 UTC 2023
Tests: 81% tests passed, 10 tests failed out of 53
	1584 - test_gdasapp_convert_bufr_temp_dbuoy (Failed)
	1585 - test_gdasapp_convert_bufr_salt_dbuoy (Failed)
	1586 - test_gdasapp_convert_bufr_temp_mbuoyb (Failed)
	1587 - test_gdasapp_convert_bufr_salt_mbuoyb (Failed)
	1588 - test_gdasapp_convert_bufr_tesacprof (Failed)
	1589 - test_gdasapp_convert_bufr_trkobprof (Failed)
	1590 - test_gdasapp_convert_bufr_sfcships (Failed)
	1591 - test_gdasapp_convert_bufr_sfcshipsu (Failed)
	1612 - test_gdasapp_convert_bufr_adpsfc_snow (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/717/global-workflow/sorc/gdas.cd/build/log.ctest

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Nov 13 17:02:04 CST 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Nov 13 17:52:43 CST 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Nov 13 18:31:22 CST 2023
Tests: 81% tests passed, 10 tests failed out of 53
	1584 - test_gdasapp_convert_bufr_temp_dbuoy (Failed)
	1585 - test_gdasapp_convert_bufr_salt_dbuoy (Failed)
	1586 - test_gdasapp_convert_bufr_temp_mbuoyb (Failed)
	1587 - test_gdasapp_convert_bufr_salt_mbuoyb (Failed)
	1588 - test_gdasapp_convert_bufr_tesacprof (Failed)
	1589 - test_gdasapp_convert_bufr_trkobprof (Failed)
	1590 - test_gdasapp_convert_bufr_sfcships (Failed)
	1591 - test_gdasapp_convert_bufr_sfcshipsu (Failed)
	1612 - test_gdasapp_convert_bufr_adpsfc_snow (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/717/global-workflow/sorc/gdas.cd/build/log.ctest

[guillaumevernieres]

I'll merge later today (unless somebody objects) since the failure are unrelated to the work done for this PR. @ShastriPaturi , could you have a look at the failing tests?