-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IODA conversions to marine obs prep task ex-script #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AndrewEichmann-NOAA . Looks good, see comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to run it once with actual data to be sure that I follow.
Approving nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Let's brain storm about the test data tomorrow @AndrewEichmann-NOAA . |
126df70
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AndrewEichmann-NOAA . Looks good, just a few minor cosmetic comments. Also, sort out your coding norm too.
Automated Global-Workflow GDASApp Testing Results:
|
Looks like a reference mismatch @apchoiCMD : The following tests FAILED:
1314 - test_gdasapp_util_smap2ioda (Subprocess aborted)
1316 - test_gdasapp_util_icecamsr2ioda (Subprocess aborted)
Errors while running CTest |
@guillaumevernieres I am fixing them now! |
@guillaumevernieres ctest passes on orion but not on hera, found out what is problem but we need to discuss it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll fix the broken test in a different PR.
As a draft PR this is to allow some mid-development input.
parm/soca/obsproc/obs_list_obsproc.yaml
is added as theOBS_LIST
for testing purposesparm/soca/obsproc/obsproc_config.yaml
is added, containing the obs source-specific info in the yamls inutils/test/testinput/
and the dictionary of observation source filename regexp patterns inush/soca/prep_marine_obs.py
- the yaml here is loaded to fetch the observation files and dynamically generate the yaml to feed to the IODA converter. I would be curious if the hierarchy or terminology breaks any established JEDI conventions.scripts/exglobal_prep_ocean_obs.py
now fetches the observation files to the RUNDIR, creates the IODA converter yaml with the input set to the filenames now returned byprep_marine_obs.obs_fetch
, and runs the IODA converters.Also: this would require some rearranging of test data - right now I'm testing against the full files we used for IODA converters, but for the ctests I presume there would have to be some arrangement like with the IODA converter ctests, making NetCDF files out of text files.
Lemme know what you think.