Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IODA conversions to marine obs prep task ex-script #719

Merged
merged 20 commits into from
Nov 30, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Nov 13, 2023

As a draft PR this is to allow some mid-development input.

  • parm/soca/obsproc/obs_list_obsproc.yaml is added as the OBS_LIST for testing purposes
  • parm/soca/obsproc/obsproc_config.yaml is added, containing the obs source-specific info in the yamls in utils/test/testinput/ and the dictionary of observation source filename regexp patterns in ush/soca/prep_marine_obs.py - the yaml here is loaded to fetch the observation files and dynamically generate the yaml to feed to the IODA converter. I would be curious if the hierarchy or terminology breaks any established JEDI conventions.
  • scripts/exglobal_prep_ocean_obs.py now fetches the observation files to the RUNDIR, creates the IODA converter yaml with the input set to the filenames now returned by prep_marine_obs.obs_fetch, and runs the IODA converters.
  • some variable names have been changed to camelCase

Also: this would require some rearranging of test data - right now I'm testing against the full files we used for IODA converters, but for the ctests I presume there would have to be some arrangement like with the IODA converter ctests, making NetCDF files out of text files.

Lemme know what you think.

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA . Looks good, see comments.

parm/soca/obsproc/obsproc_config.yaml Show resolved Hide resolved
scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment below.

ush/soca/prep_marine_obs.py Show resolved Hide resolved
ShastriPaturi
ShastriPaturi previously approved these changes Nov 13, 2023
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to run it once with actual data to be sure that I follow.
Approving nonetheless.

apchoiCMD
apchoiCMD previously approved these changes Nov 13, 2023
Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
@guillaumevernieres
Copy link
Contributor

Let's brain storm about the test data tomorrow @AndrewEichmann-NOAA .

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA . Looks good, just a few minor cosmetic comments. Also, sort out your coding norm too.

scripts/exglobal_prep_ocean_obs.py Outdated Show resolved Hide resolved
test/soca/gw/CMakeLists.txt Outdated Show resolved Hide resolved
ush/soca/run_jjobs.py Outdated Show resolved Hide resolved
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review November 29, 2023 20:50
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Nov 29, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Nov 29, 2023
@emcbot
Copy link

emcbot commented Nov 29, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Nov 29 21:02:03 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Nov 29 21:47:36 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Nov 29 22:08:52 UTC 2023
Tests: 96% tests passed, 2 tests failed out of 54
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/719/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Nov 29, 2023
@guillaumevernieres
Copy link
Contributor

Looks like a reference mismatch @apchoiCMD :

The following tests FAILED:
        1314 - test_gdasapp_util_smap2ioda (Subprocess aborted)
        1316 - test_gdasapp_util_icecamsr2ioda (Subprocess aborted)
Errors while running CTest

@apchoiCMD
Copy link
Collaborator

Looks like a reference mismatch @apchoiCMD :

The following tests FAILED:
        1314 - test_gdasapp_util_smap2ioda (Subprocess aborted)
        1316 - test_gdasapp_util_icecamsr2ioda (Subprocess aborted)
Errors while running CTest

@guillaumevernieres I am fixing them now!

@apchoiCMD
Copy link
Collaborator

Looks like a reference mismatch @apchoiCMD :

The following tests FAILED:
        1314 - test_gdasapp_util_smap2ioda (Subprocess aborted)
        1316 - test_gdasapp_util_icecamsr2ioda (Subprocess aborted)
Errors while running CTest

@guillaumevernieres ctest passes on orion but not on hera, found out what is problem but we need to discuss it tomorrow.

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fix the broken test in a different PR.

@guillaumevernieres guillaumevernieres merged commit 22f905c into develop Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants