Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix" for the increment handler application #738

Merged
merged 2 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions test/soca/testinput/incr_handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ date: 2018-04-15T09:00:00Z

layers variable: [hocn]

increment variables: [tocn, socn, uocn, vocn, ssh, hocn]
increment variables: [tocn, socn, uocn, vocn, ssh]

set increment variables to zero: [uocn, vocn, ssh]

Expand All @@ -32,21 +32,6 @@ soca increment:
# ocn_filename: 'ocn.1.nc'
# read_from_file: 1

linear variable change:
linear variable changes:
- linear variable change name: BkgErrFILT
ocean_depth_min: 500 # zero where ocean is shallower than 500m
rescale_bkgerr: 1.0 # rescale perturbation
efold_z: 1500.0 # Apply exponential decay
- linear variable change name: BalanceSOCA

trajectory:
state variables: [tocn, socn, uocn, vocn, ssh, hocn, layer_depth, mld]
date: 2018-04-15T09:00:00Z
basename: ./INPUT/
ocn_filename: MOM.res.nc
read_from_file: 1

output increment:
datadir: ./
date: 2018-04-15T09:00:00Z
Expand Down
7 changes: 0 additions & 7 deletions utils/soca/gdas_incr_handler.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,6 @@ namespace gdasapp {
// Zero out specified fields
incrWithLayer = postProcIncr.setToZero(incrWithLayer);

// Apply linear change of variables
if ( fullConfig.has("linear variable change") ) {
soca::State traj = postProcIncr.getTraj(fullConfig, geom);
eckit::LocalConfiguration lvcConfig(fullConfig, "linear variable change");
postProcIncr.applyLinVarChange(incrWithLayer, lvcConfig, traj);
}

// Save final increment
result = postProcIncr.save(incrWithLayer, i);
oops::Log::debug() << "========= after appending layer and after saving:" << std::endl;
Expand Down
Loading