Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug for dateTime in IcecAmsr2Ioda.h #756

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Fix a bug for dateTime in IcecAmsr2Ioda.h #756

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8533308
swith std-vector on Rads2Ioda
apchoiCMD Nov 17, 2023
94776a9
add additional trimming fir dateTime
apchoiCMD Nov 20, 2023
fe33aa3
Merge branch 'develop' into feature/ioda-stdvec-rads
apchoiCMD Nov 20, 2023
3552417
Merge branch 'develop' into feature/ioda-stdvec-rads
guillaumevernieres Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions utils/obsproc/IcecAmsr2Ioda.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ namespace gdasapp {
ncFile.getVar("Scan_Time").getVar(oneTmpdateTimeVal.data());
iodaVars.referenceDate_ = "seconds since 1970-01-01T00:00:00Z";

size_t index = 0;
std::tm timeinfo = {};
for (int i = 0; i < ntimes; i += dimTimeSize) {
for (int j = 0; j < dimTimeSize && i + j < ntimes; j++) {
}
timeinfo.tm_year = oneTmpdateTimeVal[i] - 1900; // Year since 1900
timeinfo.tm_mon = oneTmpdateTimeVal[i + 1] - 1; // 0-based; 8 represents Sep
timeinfo.tm_mday = oneTmpdateTimeVal[i + 2];
Expand All @@ -77,20 +76,22 @@ namespace gdasapp {

// Calculate and store the seconds since the Unix epoch
time_t epochtime = std::mktime(&timeinfo);
iodaVars.datetime_(i/6) = static_cast<int64_t>(epochtime);
iodaVars.datetime_(index) = static_cast<int64_t>(epochtime);
index++;
}

// Update non-optional Eigen arrays
for (int i = 0; i < iodaVars.location_; i++) {
iodaVars.longitude_(i) = oneDimLonVal[i];
iodaVars.latitude_(i) = oneDimLatVal[i];
iodaVars.obsVal_(i) = static_cast<float>(oneDimObsVal[i]*0.01);
iodaVars.obsVal_(i) = static_cast<float>(oneDimObsVal[i]*0.01f);
iodaVars.obsError_(i) = 0.1; // Do something for obs error
iodaVars.preQc_(i) = oneDimFlagsVal[i];
}

// basic test for iodaVars.trim
Eigen::Array<bool, Eigen::Dynamic, 1> mask = (iodaVars.obsVal_ >= 0.0);
Eigen::Array<bool, Eigen::Dynamic, 1> mask = (iodaVars.obsVal_ >= 0.0
&& iodaVars.datetime_ > 0.0);
iodaVars.trim(mask);

return iodaVars;
Expand Down
Loading