-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test reference mismatch #786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think changing the environment is a safe thing to do, you're assuming TZ
isn't used anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look here @apchoiCMD :
https://github.com/JCSDA/ioda/blob/develop/src/core/IodaUtils.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @apchoiCMD . Looks good, just a few minor comments. Did you check that the datetime is still correct?
Yes, I have checked min & max output by using online tools (UTC) compared to original netcdf data, too! Everything was ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the filtering of obs with bad dates, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @apchoiCMD .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on others comments
Automated Global-Workflow GDASApp Testing Results:
|
What this PR fixed
that work withthat need to ensure consistent behavior across different machines with different time zones (e.g., Orion (CST) and Hera (UTC))mktime
in a C library functionSet the time zone explicitly using thetzset
function with UTC time zoneoops/utils
to make dateime to Julian date so now code is a lot simpler than beforeFixed #783