Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new updates for detect_machine.sh and updates module names #115

Conversation

HenryRWinterbottom
Copy link
Contributor

This PR addresses issue #112. The following is accomplished:

  • The ush/detect_machine.sh file is updated such that it is identical to that in the UFS weather model;
  • ush/build.sh is updated to include the compiler name in the module identifier;
  • The LUA files beneath modulefiles have been updated accordingly.

@HenryRWinterbottom
Copy link
Contributor Author

@EdwardSafford-NOAA This was opened again due to a misunderstanding on my end. This now addresses the misunderstanding. I apologize for the error.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@EdwardSafford-NOAA EdwardSafford-NOAA merged commit 97be8b0 into NOAA-EMC:develop Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants