Update GH CI #61
Update GH CI #61
Conversation
|
@DavidHuber-NOAA and @AlexanderRichert-NOAA GSI-utils GH CI was failing like it was in GSI. I changed GSI-utils files following the pattern I saw in GSI PR #816. Now GH CI passes for GSI-utils. This is good but I'm simply copying what I see in GSI. Did I make the correct set of changes to GSI-utils? If you have time, would you please check the changes in this PR. Let me know what I got wrong and I'll fix it. |
RussTreadon-NOAA
requested review from
DavidHuber-NOAA and
AlexanderRichert-NOAA
|
Changes look good to me. Thanks @RussTreadon-NOAA! |
There was a problem hiding this comment.
Just one comment, probably for @AlexanderRichert-NOAA or @DavidHuber-NOAA to address, but otherwise, looks good.
.github/workflows/gcc.yml
Outdated
|
|
||
| # Install dependencies using Spack | ||
| - name: install-dependencies-with-spack | ||
| if: steps.cache-env.outputs.cache-hit != 'true' | ||
| # if: steps.cache-env.outputs.cache-hit != 'true' |
There was a problem hiding this comment.
will this not cause the stack to be built each time for gcc?
There was a problem hiding this comment.
Yes, I think you are correct. This will make the CI process quite long most of the time. This should probably be uncommented (here and in the GSI).
There was a problem hiding this comment.
Indeed, gcc CI took 38 minutes. I will uncomment the line in question and see what happens.
|
Thanks for the quick update @RussTreadon-NOAA A side note from looking at the action run -- suspect the CI will have issues soon after the GH runner is updated to a new image. |
|
Thank you @aerorahul for noting the warning. 1/17/2025 is just around the corner. I'll merge this PR into |
Update github workflows to be consistent with recent updates to the GH CI environment.
This PR follows the example of GSI PR #816 in which comparable changes were made to the GSI github CI.