Develop meso fix new ksmax #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity issues in upper atmosphere
42 tasks
…elop_meso_fix_new_ksmax
…elop_meso_fix_new_ksmax
…elop_meso_fix_new_ksmax
…elop_meso_fix_new_ksmax
jkbk2004
requested review from
junwang-noaa,
DusanJovic-NOAA and
BrianCurtis-NOAA
junwang-noaa
approved these changes
Oct 19, 2023
DusanJovic-NOAA
approved these changes
Oct 19, 2023
…elop_meso_fix_new_ksmax
|
@mdtoyNOAA ufs-community/ccpp-physics#111 was merged. Please revert .gitmodules and update the ccpp/physics pointer to the latest ufs/dev commit: ufs-community/ccpp-physics@1db5691 |
|
@jkbk2004 please feel free to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upper-atmosphere OGWD fix in drag_suite.F90. See: Issue #95 and CCPP-PHYSICS PR#111.
Added two suite definition files for exercising UGWPv1 physics, i.e., UGWP with GSL orographic gravity wave drag + blocking + version 1 non-stationary gravity wave drag.
This PR changes RT results.
Issue(s) addressed
Testing
These changes were tested with regression tests for Intel and GNU compilers on Hera.
The OGWD fixes are tested by existing RT's, but we also added two tests for exercising UGWPv1 physics.
Dependencies
N/A