Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow cpllnd to use inst lw and sw down #711

Merged
merged 5 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
#url = https://github.com/ufs-community/ccpp-physics
#branch = ufs/dev
url = https://github.com/DeniseWorthen/ccpp-physics
branch = feature/lndinst
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
146 changes: 73 additions & 73 deletions ccpp/data/GFS_typedefs.F90

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions ccpp/data/GFS_typedefs.meta
Original file line number Diff line number Diff line change
Expand Up @@ -2541,15 +2541,15 @@
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
active = (flag_for_surface_flux_coupling)
active = (flag_for_surface_flux_coupling .or. flag_for_land_coupling)
[dswsfci_cpl]
standard_name = surface_downwelling_shortwave_flux_for_coupling
long_name = instantaneous sfc downward sw flux
units = W m-2
dimensions = (horizontal_loop_extent)
type = real
kind = kind_phys
active = (flag_for_surface_flux_coupling)
active = (flag_for_surface_flux_coupling .or. flag_for_land_coupling)
[dnirbmi_cpl]
standard_name = surface_downwelling_direct_nir_shortwave_flux_for_coupling
long_name = instantaneous sfc nir beam downward sw flux
Expand Down Expand Up @@ -2845,7 +2845,7 @@
kind = kind_phys
active = (do_stochastically_perturbed_parameterizations)
[spp_wts_sfc]
standard_name = spp_weights_for_surface_layer_scheme
standard_name = spp_weights_for_surface_layer_scheme
long_name = spp weights for surface layer scheme
units = 1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
Expand All @@ -2854,23 +2854,23 @@
active = (do_stochastically_perturbed_parameterizations)
[spp_wts_mp]
standard_name = spp_weights_for_microphysics_scheme
long_name = spp weights for microphysics scheme
long_name = spp weights for microphysics scheme
units = 1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
active = (do_stochastically_perturbed_parameterizations)
[spp_wts_gwd]
standard_name = spp_weights_for_gravity_wave_drag_scheme
long_name = spp weights for gravity wave drag scheme
long_name = spp weights for gravity wave drag scheme
units = 1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
kind = kind_phys
active = (do_stochastically_perturbed_parameterizations)
[spp_wts_rad]
standard_name = spp_weights_for_radiation_scheme
long_name = spp weights for radiation scheme
long_name = spp weights for radiation scheme
units = 1
dimensions = (horizontal_loop_extent,vertical_layer_dimension)
type = real
Expand Down Expand Up @@ -3672,7 +3672,7 @@
type = integer
[inc_minor_gas]
standard_name = flag_to_include_minor_gases_in_rrtmg
long_name = flag to include minor trace gases in rrtmg
long_name = flag to include minor trace gases in rrtmg
units = flag
dimensions = ()
type = logical
Expand Down Expand Up @@ -6283,7 +6283,7 @@
type = integer
[ntbcl]
standard_name = index_for_bcphilic
long_name = index for bcphilic
long_name = index for bcphilic
units = index
dimensions = ()
type = integer
Expand All @@ -6295,7 +6295,7 @@
type = integer
[ntocl]
standard_name = index_for_ocphilic
long_name = index for ocphilic
long_name = index for ocphilic
units = index
dimensions = ()
type = integer
Expand Down
2 changes: 1 addition & 1 deletion ccpp/physics
8 changes: 4 additions & 4 deletions fv3_cap.F90
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ subroutine InitializeAdvertise(gcomp, rc)

noutput_fh = ESMF_ConfigGetLen(config=CF, label ='output_fh:',rc=rc)

if(mype == 0) print *,'af nems config,quilting=',quilting,' calendar=', trim(calendar),' iau_offset=',iau_offset, &
if(mype == 0) print *,'af ufs config,quilting=',quilting,' calendar=', trim(calendar),' iau_offset=',iau_offset, &
' noutput_fh=',noutput_fh
!
nfhout = 0 ; nfhmax_hf = 0 ; nfhout_hf = 0 ; nsout = 0
Expand All @@ -320,7 +320,7 @@ subroutine InitializeAdvertise(gcomp, rc)
label ='isrcTermProcessing:',rc=rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return

if(mype == 0) print *,'af nems config,quilting=',quilting,' write_groups=', &
if(mype == 0) print *,'af ufs config,quilting=',quilting,' write_groups=', &
write_groups,wrttasks_per_group_from_parent,' isrcTermProcessing=', isrcTermProcessing
!
call ESMF_ConfigGetAttribute(config=CF,value=num_files, &
Expand All @@ -341,15 +341,15 @@ subroutine InitializeAdvertise(gcomp, rc)
call ESMF_ConfigGetAttribute(config=CF, value=nsout, label ='nsout:', default=-1,rc=rc)
nsout_io = nsout
!
if(mype==0) print *,'af nems config,nfhout,nsout=',nfhout,nfhmax_hf,nfhout_hf, nsout,noutput_fh
if(mype==0) print *,'af ufs config,nfhout,nsout=',nfhout,nfhmax_hf,nfhout_hf, nsout,noutput_fh

call ESMF_ConfigGetAttribute(config=CF, value=time_unlimited, label ='time_unlimited:', default=.false., rc=rc)

endif ! quilting
!
call ESMF_ConfigGetAttribute(config=CF, value=dt_atmos, label ='dt_atmos:', rc=rc)
call ESMF_ConfigGetAttribute(config=CF, value=nfhmax, label ='nhours_fcst:',rc=rc)
if(mype == 0) print *,'af nems config,dt_atmos=',dt_atmos,'nfhmax=',nfhmax
if(mype == 0) print *,'af ufs config,dt_atmos=',dt_atmos,'nfhmax=',nfhmax

call ESMF_TimeIntervalSet(timeStep, s=dt_atmos, rc=rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
Expand Down
4 changes: 2 additions & 2 deletions module_fcst_grid_comp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -606,14 +606,14 @@ subroutine fcst_initialize(fcst_comp, importState, exportState, clock, rc)

num_restart_interval = ESMF_ConfigGetLen(config=CF, label ='restart_interval:',rc=rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
if (mype == 0) print *,'af nems config,num_restart_interval=',num_restart_interval
if (mype == 0) print *,'af ufs config,num_restart_interval=',num_restart_interval
if (num_restart_interval<=0) num_restart_interval = 1
allocate(restart_interval(num_restart_interval))
restart_interval = 0
call ESMF_ConfigGetAttribute(CF,valueList=restart_interval,label='restart_interval:', &
count=num_restart_interval, rc=rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
if (mype == 0) print *,'af nems config,restart_interval=',restart_interval
if (mype == 0) print *,'af ufs config,restart_interval=',restart_interval
!
call fms_init(fcst_mpi_comm)
call mpp_init()
Expand Down