Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync support to integrate PR #743 to Use MPI_Bcast instead of multiple p2p messages to update nest #771

Closed
wants to merge 2 commits into from

Conversation

jkbk2004
Copy link
Collaborator

@jkbk2004 jkbk2004 commented Jan 19, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.

Dependencies

Do PRs in upstream repositories need to be merged first?
This PR depends on merging of PR 272 into the GFDL_atmos_cubed_sphere
NOAA-GFDL/GFDL_atmos_cubed_sphere#272

@jkbk2004
Copy link
Collaborator Author

jkbk2004 commented Jan 19, 2024

@dkokron I still see sync issue on your feature branch. Instead of directly fixing on your branch, I am trying to replace #743 with this PR. We are supposed to code changes only in NOAA-GFDL/GFDL_atmos_cubed_sphere#272 @DusanJovic-NOAA @junwang-noaa Can I ask to review and approve?

@jkbk2004 jkbk2004 requested a review from BinLiu-NOAA January 19, 2024 19:03
@DusanJovic-NOAA
Copy link
Collaborator

What are the sync issues in 743?

@junwang-noaa
Copy link
Collaborator

@jkbk2004 We have some documentation updates committed to fv3atm, please sync.

@dkokron
Copy link
Contributor

dkokron commented Jan 19, 2024 via email

@DusanJovic-NOAA
Copy link
Collaborator

I do not see the purpose of this PR. I do not see any difference between this PR and #743. We should not create new PRs just to replace the original PR. This just creates confusion.

@jkbk2004
Copy link
Collaborator Author

I do not see the purpose of this PR. I do not see any difference between this PR and #743. We should not create new PRs just to replace the original PR. This just creates confusion.

Closing this pr. I cleaned up unnecessary file changes in #743: atmos_model.F90 module_wrt_grid_comp.F90 fv_moving_nest_main.F90.

@jkbk2004 jkbk2004 closed this Jan 19, 2024
@jkbk2004 jkbk2004 deleted the feature/mpi_bcast branch April 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants