[Production/RRFS.v1] MYNN PBL, Smoke and subgrid cloud fraction updates RRFS.v1 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grantfirl Yes, #801 has been combined. |
|
@haiqinli physics and cubed sphere PRs were merged. can you update hash and revert change in gitmodules? |
|
@jkbk2004 The gitmodules have been reverted. Thanks. |
|
@haiqinli correct hashes are ufs-community/ccpp-physics@85fabc0 and NOAA-EMC/GFDL_atmos_cubed_sphere@fab198c can you cehck one more time? |
|
@jkbk2004 Updates for the correct hashes of ufs-community/ccpp-physics@85fabc0 and NOAA-EMC/GFDL_atmos_cubed_sphere@fab198c are done. Thanks. |
|
looks good! @MatthewPyle-NOAA this pr can be merged: with concise squash/merge commit message. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
-- Update the MYNN PBL, Smoke and subgrid cloud fraction for the RRFS.v1 code freeze.
What bug does it fix, or what feature does it add?
-- Merge the bugfix in the HAILCAST diagnostic code (unit issue) (#320)
-- Merge (#801)
Is a change of answers expected from this PR? Yes.
Testing
How were these changes tested? The changes were tested with retro runs and regression test.
What compilers / HPCs was it tested with? Intel compiler on Hera and Jet.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera.
Yes, because the physics changed.
Yes, the regression test log file was committed.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs